Fix Voluntary Exits Panic #5688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayzluf
reviewed
Apr 30, 2020
Co-Authored-By: Shay Zluf <[email protected]>
shayzluf
reviewed
Apr 30, 2020
Comment on lines
173
to
181
| _, err = server.ProposeExit(context.Background(), req) | ||
| if err == nil { | ||
| t.Fatal("Expected error for no signature existing existing") | ||
| } | ||
|
|
||
| _, err = server.ProposeExit(context.Background(), req) | ||
| if err == nil { | ||
| t.Fatal("Expected error for no signature existing existing") | ||
| } |
There was a problem hiding this comment.
Suggested change
| _, err = server.ProposeExit(context.Background(), req) | |
| if err == nil { | |
| t.Fatal("Expected error for no signature existing existing") | |
| } | |
| _, err = server.ProposeExit(context.Background(), req) | |
| if err == nil { | |
| t.Fatal("Expected error for no signature existing existing") | |
| } | |
| _, err = server.ProposeExit(context.Background(), req) | |
| if err == nil { | |
| t.Fatal("Expected error for no signature existing existing") | |
| } |
shayzluf
reviewed
Apr 30, 2020
Co-Authored-By: Shay Zluf <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #5688 +/- ##
===========================================
- Coverage 41.86% 19.98% -21.89%
===========================================
Files 272 239 -33
Lines 23273 20895 -2378
===========================================
- Hits 9744 4175 -5569
- Misses 11762 15923 +4161
+ Partials 1767 797 -970 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
It prevents the rpc server from panicking if it receives an invalid exit proposal. It checks that
the exit object exists and that the signature is valid.
A regression test has also been added
Which issues(s) does this PR fix?
N.A
Other notes for review